linux-kernel - Re: [PATCH v3 0/2] mfd: rn5t618: Extend ADC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Jul 2021 18:08:02 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Andreas Kemnade <andreas@...nade.info>, lars@...afoo.de,
        sre@...nel.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        letux-kernel@...nphoenux.org
Subject: Re: [PATCH v3 0/2] mfd: rn5t618: Extend ADC support

On Tue, 13 Jul 2021 09:27:27 +0100
Lee Jones <lee.jones@...aro.org> wrote:

> On Mon, 12 Jul 2021, Andreas Kemnade wrote:
> 
> > Add iio map to make voltage_now related channels accessible to power
> > driver.
> > 
> > Changes in v3:
> > - use scale functions
> > - add acks
> > 
> > Changes in v2:
> > - use iio_map instead of devicetree to allow mapping which does not
> >   block future extension by devicetree.
> > 
> > 
> > *** BLURB HERE ***  
> 
> Doh!
> 
> > Andreas Kemnade (2):
> >   iio: adc: rn5t618: Add iio map
> >   power: supply: rn5t618: Add voltage_now property
> > 
> >  drivers/iio/adc/rn5t618-adc.c        | 23 +++++++++++++++++
> >  drivers/power/supply/Kconfig         |  2 ++
> >  drivers/power/supply/rn5t618_power.c | 38 ++++++++++++++++++++++++++++
> >  3 files changed, 63 insertions(+)  
> 
> Not sure I get this.
> 
> Firstly, the cover-letter is marked as MFD, but no MFD changes occur.

So this is a bit of a fun corner case.  The series 'used' to include an mfd
change that made that labelling relevant.  Then that went away as I suggested
that we could do it in a simpler fashion.
Under the circumstances the series needed a rename!

> Secondly, I am only in receipt of the 0th patch which seems odd.  IMHO
> patch sets should be sent threaded and all parties should see
> discussion on all patches regardless of whether they maintain them or
> not, since the overall conversation is often useful/relevant to all.
> 
Absolutely agree for small series like this.

Anyhow, as far as I'm concerned this is now in the hands of the power supply
maintainers anyway so ignoring it ;)

Jonathan