linux-kernel - Re: [PATCH AUTOSEL 4.19 05/39] scsi: hisi_sas: Propagate errors in interrupt_init_v1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 18 Jul 2021 12:13:45 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Sasha Levin <sashal@...nel.org>
CC:     <linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>,
        John Garry <john.garry@...wei.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH AUTOSEL 4.19 05/39] scsi: hisi_sas: Propagate errors in
 interrupt_init_v1_hw()

Hello!

On 18.07.2021 4:20, Sasha Levin wrote:

[...]
>>> [ Upstream commit ab17122e758ef68fb21033e25c041144067975f5 ]
>>>
>>> After commit 6c11dc060427 ("scsi: hisi_sas: Fix IRQ checks") we have the
>>> error codes returned by platform_get_irq() ready for the propagation
>>> upsream in interrupt_init_v1_hw() -- that will fix still broken deferred
>>> probing. Let's propagate the error codes from devm_request_irq() as well
>>> since I don't see the reason to override them with -ENOENT...
>>>
>>> Link: https://lore.kernel.org/r/49ba93a3-d427-7542-d85a-b74fe1a33a73@omp.ru
>>> Acked-by: John Garry <john.garry@...wei.com>
>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@....ru>
>>> Signed-off-by: Martin K. Petersen <martin.petersen@...cle.com>
>>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>>> ---
>>>  drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 12 ++++++------
>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c 
>>> b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
>>> index 8aa3222fe486..5a777e48963b 100644
>>> --- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
>>> +++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
>> [...]
>>> @@ -1717,7 +1717,7 @@ static int interrupt_init_v1_hw(struct hisi_hba 
>>> *hisi_hba)
>>>          if (!irq) {
>>>              dev_err(dev, "irq init: could not map cq interrupt %d\n",
>>>                  idx);
>>> -            return -ENOENT;
>>> +            return irq;
>>
>>   This patch is borked too, we don't want to return 0 here...
> 
> Looks like it's broken on <=4.19, I'll drop it. Thanks!

    You might to want backport the below patch (before this one),
the same way yoo did for 5.x-stable):

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6c11dc060427e07ca144eacaccd696106b361b06

MBR, Sergei