linux-kernel - Re: [for-next][PATCH 19/24] tracing: Add LATENCY_FS_NOTIFY to define if latency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a3aXP2+oXQMWE-4tagcy3O+1-K_gt+p10uXaxkBk-sF9w@mail.gmail.com>
Date:   Tue, 20 Jul 2021 21:19:01 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [for-next][PATCH 19/24] tracing: Add LATENCY_FS_NOTIFY to define
 if latency_fsnotify() is defined

On Sat, Jun 26, 2021 at 3:10 PM Steven Rostedt <rostedt@...dmis.org> wrote:
>
> From: "Steven Rostedt (VMware)" <rostedt@...dmis.org>
>
> With the coming addition of the osnoise tracer, the configs needed to
> include the latency_fsnotify() has become more complex, and to keep the
> declaration in the header file the same as in the C file, just have the
> logic needed to define it in one place, and that defines LATENCY_FS_NOTIFY
> which will be used in the C code.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

This still doesn't seem quite right. I just came across this randconfig build
warning on 5.14-rc2:

kernel/trace/trace.c:1712:13: error: 'trace_create_maxlat_file'
defined but not used [-Werror=unused-function]
 1712 | static void trace_create_maxlat_file(struct trace_array *tr,

See https://pastebin.com/raw/b3DH7hWg for the .config that triggered it.

       Arnd