linux-kernel - Re: [PATCH][next] ALSA: sc6000: Fix incorrect sizeof operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5htukpnef8.wl-tiwai@suse.de>
Date:   Tue, 20 Jul 2021 18:22:19 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Colin King <colin.king@...onical.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] ALSA: sc6000: Fix incorrect sizeof operator

On Tue, 20 Jul 2021 18:17:07 +0200,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> Static analysis is warning that the sizeof being used is should be
> of *vport and not vport. Although these are the same size it is not
> a portable assumption to assume this is true for all cases.  Fix this
> by using sizeof(*vport).
> 
> Addresses-Coverity: ("Sizeof not portable")
> Fixes: 111601ff76e9 ("ALSA: sc6000: Allocate resources with device-managed APIs")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks.  I have another patch to drop this allocation (it's just a
pointer, so no need for kmalloc, really), but since your patch is
correct, I'll rebase on yours.


Takashi