linux-kernel - Re: [PATCH v14 5/9] staging: hi6421-spmi-pmic: cleanup drvdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YPfoGzCtS7sBFESm@kroah.com>
Date:   Wed, 21 Jul 2021 11:25:47 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     linuxarm@...wei.com, mauro.chehab@...wei.com,
        Arnd Bergmann <arnd@...db.de>,
        Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH v14 5/9] staging: hi6421-spmi-pmic: cleanup drvdata

On Sat, Jul 17, 2021 at 11:58:16AM +0200, Mauro Carvalho Chehab wrote:
> There are lots of fields at struct hi6421_spmi_pmic that aren't
> used. In a matter of fact, only regmap is needed.
> 
> So, drop the struct as a hole, and set just the regmap as
> the drvdata.
> 
> While here, add a missing dot at the Huawei's copyrights.
> 
> Acked-by: Mark Brown <broonie@...nel.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> ---
>  drivers/misc/hi6421v600-irq.c               |  9 ++++----
>  drivers/regulator/hi6421v600-regulator.c    | 10 ++++-----
>  drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 16 +++++--------
>  include/linux/mfd/hi6421-spmi-pmic.h        | 25 ---------------------
>  4 files changed, 14 insertions(+), 46 deletions(-)
>  delete mode 100644 include/linux/mfd/hi6421-spmi-pmic.h

This patch fails to apply to my 5.14-rc2 tree, it gets a failure in the
regulator portion of the patch.

thanks,

greg k-h