linux-kernel - Re: [PATCH v14 5/9] staging: hi6421-spmi-pmic: cleanup drvdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Jul 2021 12:10:31 +0200
From:   Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mark Brown <broonie@...nel.org>
Cc:     linuxarm@...wei.com, mauro.chehab@...wei.com,
        Arnd Bergmann <arnd@...db.de>,
        Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v14 5/9] staging: hi6421-spmi-pmic: cleanup drvdata

Em Wed, 21 Jul 2021 11:25:47 +0200
Greg Kroah-Hartman <gregkh@...uxfoundation.org> escreveu:

> On Sat, Jul 17, 2021 at 11:58:16AM +0200, Mauro Carvalho Chehab wrote:
> > There are lots of fields at struct hi6421_spmi_pmic that aren't
> > used. In a matter of fact, only regmap is needed.
> > 
> > So, drop the struct as a hole, and set just the regmap as
> > the drvdata.
> > 
> > While here, add a missing dot at the Huawei's copyrights.
> > 
> > Acked-by: Mark Brown <broonie@...nel.org>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> > ---
> >  drivers/misc/hi6421v600-irq.c               |  9 ++++----
> >  drivers/regulator/hi6421v600-regulator.c    | 10 ++++-----
> >  drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 16 +++++--------
> >  include/linux/mfd/hi6421-spmi-pmic.h        | 25 ---------------------
> >  4 files changed, 14 insertions(+), 46 deletions(-)
> >  delete mode 100644 include/linux/mfd/hi6421-spmi-pmic.h  
> 
> This patch fails to apply to my 5.14-rc2 tree, it gets a failure in the
> regulator portion of the patch.

Hi Greg,

This one depends on a regression-fix patch merged via this branch:

	https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

The patch is this one[1]:

	https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/drivers/regulator/hi6421v600-regulator.c?id=5db5dd5be70eaf808d9fd90174b957fc5c2912cb

Mark,

Is this branch stable or do you rebase it? 

If the branch is stable, then perhaps Greg could merge from it before
applying the remaining patches from this series.

-

[1] There's no need of backporting the fix to stable, as the driver
    won't work with upstream Kernels without patches 8 and 9 from 
    this series containing the Open Firmware data needed to probe it.

Thanks,
Mauro