linux-kernel - Re: [PATCH v2 3/4] afs: Fix setting of writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Jul 2021 09:52:45 -0300
From:   Marc Dionne <marc.dionne@...istor.com>
To:     David Howells <dhowells@...hat.com>
Cc:     linux-afs@...ts.infradead.org, linux-fsdevel@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/4] afs: Fix setting of writeback_index

On Mon, Jul 12, 2021 at 1:28 PM David Howells <dhowells@...hat.com> wrote:
>
> Fix afs_writepages() to always set mapping->writeback_index to a page index
> and not a byte position[1].
>
> Fixes: 31143d5d515e ("AFS: implement basic file write support")
> Reported-by: Marc Dionne <marc.dionne@...istor.com>
> Signed-off-by: David Howells <dhowells@...hat.com>
> Link: https://lore.kernel.org/r/CAB9dFdvHsLsw7CMnB+4cgciWDSqVjuij4mH3TaXnHQB8sz5rHw@mail.gmail.com/ [1]
> cc: linux-afs@...ts.infradead.org
> ---
>
>  fs/afs/write.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/afs/write.c b/fs/afs/write.c
> index 1ed62e0ccfe5..c0534697268e 100644
> --- a/fs/afs/write.c
> +++ b/fs/afs/write.c
> @@ -784,7 +784,7 @@ int afs_writepages(struct address_space *mapping,
>         } else if (wbc->range_start == 0 && wbc->range_end == LLONG_MAX) {
>                 ret = afs_writepages_region(mapping, wbc, 0, LLONG_MAX, &next);
>                 if (wbc->nr_to_write > 0 && ret == 0)
> -                       mapping->writeback_index = next;
> +                       mapping->writeback_index = next / PAGE_SIZE;
>         } else {
>                 ret = afs_writepages_region(mapping, wbc,
>                                             wbc->range_start, wbc->range_end, &next);
>
>
>

Reviewed-by: Marc Dionne <marc.dionne@...istor.com>

Marc