linux-kernel - Re: [PATCH v3] include: linux: Reorganize timekeeping and ktime headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202107230207.DlgYh8M5-lkp@intel.com>
Date:   Fri, 23 Jul 2021 02:19:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Carlos Bilbao <bilbao@...edu>, Thomas Gleixner <tglx@...utronix.de>
Cc:     kbuild-all@...ts.01.org, Arnd Bergmann <arnd@...db.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>, jianyong.wu@....com,
        Matthew Wilcox <willy@...radead.org>, catalin.marinas@....com,
        linux-arm-kernel@...ts.infradead.org, akpm@...ux-foundation.org
Subject: Re: [PATCH v3] include: linux: Reorganize timekeeping and ktime
 headers

Hi Carlos,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/timers/core]
[also build test WARNING on kvmarm/next abelloni/rtc-next sound/for-next soc/for-next linus/master tip/x86/core v5.14-rc2 next-20210722]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Carlos-Bilbao/include-linux-Reorganize-timekeeping-and-ktime-headers/20210722-233301
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 2d0a9eb23ccfdf11308bec6db0bc007585d919d2
config: x86_64-randconfig-a003-20210722 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/e35011219261f218feeaea55c97d4d583d9747a9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Carlos-Bilbao/include-linux-Reorganize-timekeeping-and-ktime-headers/20210722-233301
        git checkout e35011219261f218feeaea55c97d4d583d9747a9
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> arch/x86/kernel/rtc.c:148:5: warning: no previous prototype for 'update_persistent_clock64' [-Wmissing-prototypes]
     148 | int update_persistent_clock64(struct timespec64 now)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~
>> arch/x86/kernel/rtc.c:154:6: warning: no previous prototype for 'read_persistent_clock64' [-Wmissing-prototypes]
     154 | void read_persistent_clock64(struct timespec64 *ts)
         |      ^~~~~~~~~~~~~~~~~~~~~~~


vim +/update_persistent_clock64 +148 arch/x86/kernel/rtc.c

fe599f9fbc5d470 Thomas Gleixner 2008-01-30  147  
e27c49291a7fe9d Arnd Bergmann   2018-04-27 @148  int update_persistent_clock64(struct timespec64 now)
fe599f9fbc5d470 Thomas Gleixner 2008-01-30  149  {
3565184ed0c1ea4 David Vrabel    2013-05-13  150  	return x86_platform.set_wallclock(&now);
fe599f9fbc5d470 Thomas Gleixner 2008-01-30  151  }
fe599f9fbc5d470 Thomas Gleixner 2008-01-30  152  
fe599f9fbc5d470 Thomas Gleixner 2008-01-30  153  /* not static: needed by APM */
e27c49291a7fe9d Arnd Bergmann   2018-04-27 @154  void read_persistent_clock64(struct timespec64 *ts)
fe599f9fbc5d470 Thomas Gleixner 2008-01-30  155  {
3565184ed0c1ea4 David Vrabel    2013-05-13  156  	x86_platform.get_wallclock(ts);
fe599f9fbc5d470 Thomas Gleixner 2008-01-30  157  }
fe599f9fbc5d470 Thomas Gleixner 2008-01-30  158  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (35184 bytes)