lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 22 Jul 2021 18:25:12 +0000
From:   "Nikolova, Tatyana E" <tatyana.e.nikolova@...el.com>
To:     Nitesh Narayan Lal <nitesh@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "mtosatti@...hat.com" <mtosatti@...hat.com>,
        "mingo@...nel.org" <mingo@...nel.org>,
        "jbrandeb@...nel.org" <jbrandeb@...nel.org>,
        "frederic@...nel.org" <frederic@...nel.org>,
        "juri.lelli@...hat.com" <juri.lelli@...hat.com>,
        "abelits@...vell.com" <abelits@...vell.com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
        "stephen@...workplumber.org" <stephen@...workplumber.org>,
        "rppt@...ux.vnet.ibm.com" <rppt@...ux.vnet.ibm.com>,
        "chris.friesen@...driver.com" <chris.friesen@...driver.com>,
        "maz@...nel.org" <maz@...nel.org>,
        "nhorman@...driver.com" <nhorman@...driver.com>,
        "pjwaskiewicz@...il.com" <pjwaskiewicz@...il.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "thenzl@...hat.com" <thenzl@...hat.com>,
        "kashyap.desai@...adcom.com" <kashyap.desai@...adcom.com>,
        "sumit.saxena@...adcom.com" <sumit.saxena@...adcom.com>,
        "shivasharan.srikanteshwara@...adcom.com" 
        <shivasharan.srikanteshwara@...adcom.com>,
        "sathya.prakash@...adcom.com" <sathya.prakash@...adcom.com>,
        "sreekanth.reddy@...adcom.com" <sreekanth.reddy@...adcom.com>,
        "suganath-prabu.subramani@...adcom.com" 
        <suganath-prabu.subramani@...adcom.com>,
        "james.smart@...adcom.com" <james.smart@...adcom.com>,
        "dick.kennedy@...adcom.com" <dick.kennedy@...adcom.com>,
        "jkc@...hat.com" <jkc@...hat.com>,
        "Latif, Faisal" <faisal.latif@...el.com>,
        "Saleem, Shiraz" <shiraz.saleem@...el.com>,
        "tariqt@...dia.com" <tariqt@...dia.com>,
        "ahleihel@...hat.com" <ahleihel@...hat.com>,
        "kheib@...hat.com" <kheib@...hat.com>,
        "borisp@...dia.com" <borisp@...dia.com>,
        "saeedm@...dia.com" <saeedm@...dia.com>,
        "benve@...co.com" <benve@...co.com>,
        "govind@....com" <govind@....com>,
        "jassisinghbrar@...il.com" <jassisinghbrar@...il.com>,
        "ajit.khaparde@...adcom.com" <ajit.khaparde@...adcom.com>,
        "sriharsha.basavapatna@...adcom.com" 
        <sriharsha.basavapatna@...adcom.com>,
        "somnath.kotur@...adcom.com" <somnath.kotur@...adcom.com>,
        "nilal@...hat.com" <nilal@...hat.com>,
        "Ismail, Mustafa" <mustafa.ismail@...el.com>,
        "ahs3@...hat.com" <ahs3@...hat.com>,
        "leonro@...dia.com" <leonro@...dia.com>,
        "chandrakanth.patil@...adcom.com" <chandrakanth.patil@...adcom.com>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
        "yongqiang.niu@...iatek.com" <yongqiang.niu@...iatek.com>,
        "baolin.wang7@...il.com" <baolin.wang7@...il.com>,
        "poros@...hat.com" <poros@...hat.com>,
        "minlei@...hat.com" <minlei@...hat.com>,
        "emilne@...hat.com" <emilne@...hat.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "_govind@....com" <_govind@....com>,
        "kabel@...nel.org" <kabel@...nel.org>,
        "viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
        "Tushar.Khandelwal@....com" <Tushar.Khandelwal@....com>,
        "kuba@...nel.org" <kuba@...nel.org>
Subject: RE: [PATCH v5 06/14] RDMA/irdma: Use irq_update_affinity_hint



> -----Original Message-----
> From: Nitesh Narayan Lal <nitesh@...hat.com>
> Sent: Tuesday, July 20, 2021 6:26 PM
> To: linux-kernel@...r.kernel.org; linux-scsi@...r.kernel.org; intel-wired-
> lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-api@...r.kernel.org;
> linux-pci@...r.kernel.org; tglx@...utronix.de; Brandeburg, Jesse
> <jesse.brandeburg@...el.com>; robin.murphy@....com;
> mtosatti@...hat.com; mingo@...nel.org; jbrandeb@...nel.org;
> frederic@...nel.org; juri.lelli@...hat.com; abelits@...vell.com;
> bhelgaas@...gle.com; rostedt@...dmis.org; peterz@...radead.org;
> davem@...emloft.net; akpm@...ux-foundation.org; sfr@...b.auug.org.au;
> stephen@...workplumber.org; rppt@...ux.vnet.ibm.com;
> chris.friesen@...driver.com; maz@...nel.org; nhorman@...driver.com;
> pjwaskiewicz@...il.com; sassmann@...hat.com; thenzl@...hat.com;
> kashyap.desai@...adcom.com; sumit.saxena@...adcom.com;
> shivasharan.srikanteshwara@...adcom.com;
> sathya.prakash@...adcom.com; sreekanth.reddy@...adcom.com;
> suganath-prabu.subramani@...adcom.com; james.smart@...adcom.com;
> dick.kennedy@...adcom.com; jkc@...hat.com; Latif, Faisal
> <faisal.latif@...el.com>; Saleem, Shiraz <shiraz.saleem@...el.com>;
> tariqt@...dia.com; ahleihel@...hat.com; kheib@...hat.com;
> borisp@...dia.com; saeedm@...dia.com; benve@...co.com;
> govind@....com; jassisinghbrar@...il.com;
> ajit.khaparde@...adcom.com; sriharsha.basavapatna@...adcom.com;
> somnath.kotur@...adcom.com; nilal@...hat.com; Nikolova, Tatyana E
> <tatyana.e.nikolova@...el.com>; Ismail, Mustafa
> <mustafa.ismail@...el.com>; ahs3@...hat.com; leonro@...dia.com;
> chandrakanth.patil@...adcom.com; bjorn.andersson@...aro.org;
> chunkuang.hu@...nel.org; yongqiang.niu@...iatek.com;
> baolin.wang7@...il.com; poros@...hat.com; minlei@...hat.com;
> emilne@...hat.com; jejb@...ux.ibm.com; martin.petersen@...cle.com;
> _govind@....com; kabel@...nel.org; viresh.kumar@...aro.org;
> Tushar.Khandelwal@....com; kuba@...nel.org
> Subject: [PATCH v5 06/14] RDMA/irdma: Use irq_update_affinity_hint
> 
> The driver uses irq_set_affinity_hint() to update the affinity_hint mask that
> is consumed by the userspace to distribute the interrupts. However, under
> the hood irq_set_affinity_hint() also applies the provided cpumask (if not
> NULL) as the affinity for the given interrupt which is an undocumented side
> effect.
> 
> To remove this side effect irq_set_affinity_hint() has been marked as
> deprecated and new interfaces have been introduced. Hence, replace the
> irq_set_affinity_hint() with the new interface irq_update_affinity_hint() that
> only updates the affinity_hint pointer.
> 
> Signed-off-by: Nitesh Narayan Lal <nitesh@...hat.com>
> ---
>  drivers/infiniband/hw/irdma/hw.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/irdma/hw.c
> b/drivers/infiniband/hw/irdma/hw.c
> index 7afb8a6a0526..ec8de708a4df 100644
> --- a/drivers/infiniband/hw/irdma/hw.c
> +++ b/drivers/infiniband/hw/irdma/hw.c
> @@ -537,7 +537,7 @@ static void irdma_destroy_irq(struct irdma_pci_f *rf,
>  	struct irdma_sc_dev *dev = &rf->sc_dev;
> 
>  	dev->irq_ops->irdma_dis_irq(dev, msix_vec->idx);
> -	irq_set_affinity_hint(msix_vec->irq, NULL);
> +	irq_update_affinity_hint(msix_vec->irq, NULL);
>  	free_irq(msix_vec->irq, dev_id);
>  }
> 
> @@ -1087,7 +1087,7 @@ irdma_cfg_ceq_vector(struct irdma_pci_f *rf,
> struct irdma_ceq *iwceq,
>  	}
>  	cpumask_clear(&msix_vec->mask);
>  	cpumask_set_cpu(msix_vec->cpu_affinity, &msix_vec->mask);
> -	irq_set_affinity_hint(msix_vec->irq, &msix_vec->mask);
> +	irq_update_affinity_hint(msix_vec->irq, &msix_vec->mask);
>  	if (status) {
>  		ibdev_dbg(&rf->iwdev->ibdev, "ERR: ceq irq config fail\n");
>  		return IRDMA_ERR_CFG;
> --
> 2.27.0

Acked-by: Tatyana Nikolova <tatyana.e.nikolova@...el.com>

Powered by blists - more mailing lists