lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Jul 2021 10:15:12 -0700 From: James Smart <jsmart2021@...il.com> To: Nitesh Narayan Lal <nitesh@...hat.com>, linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org, intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org, linux-api@...r.kernel.org, linux-pci@...r.kernel.org, tglx@...utronix.de, jesse.brandeburg@...el.com, robin.murphy@....com, mtosatti@...hat.com, mingo@...nel.org, jbrandeb@...nel.org, frederic@...nel.org, juri.lelli@...hat.com, abelits@...vell.com, bhelgaas@...gle.com, rostedt@...dmis.org, peterz@...radead.org, davem@...emloft.net, akpm@...ux-foundation.org, sfr@...b.auug.org.au, stephen@...workplumber.org, rppt@...ux.vnet.ibm.com, chris.friesen@...driver.com, maz@...nel.org, nhorman@...driver.com, pjwaskiewicz@...il.com, sassmann@...hat.com, thenzl@...hat.com, kashyap.desai@...adcom.com, sumit.saxena@...adcom.com, shivasharan.srikanteshwara@...adcom.com, sathya.prakash@...adcom.com, sreekanth.reddy@...adcom.com, suganath-prabu.subramani@...adcom.com, james.smart@...adcom.com, dick.kennedy@...adcom.com, jkc@...hat.com, faisal.latif@...el.com, shiraz.saleem@...el.com, tariqt@...dia.com, ahleihel@...hat.com, kheib@...hat.com, borisp@...dia.com, saeedm@...dia.com, benve@...co.com, govind@....com, jassisinghbrar@...il.com, ajit.khaparde@...adcom.com, sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com, nilal@...hat.com, tatyana.e.nikolova@...el.com, mustafa.ismail@...el.com, ahs3@...hat.com, leonro@...dia.com, chandrakanth.patil@...adcom.com, bjorn.andersson@...aro.org, chunkuang.hu@...nel.org, yongqiang.niu@...iatek.com, baolin.wang7@...il.com, poros@...hat.com, minlei@...hat.com, emilne@...hat.com, jejb@...ux.ibm.com, martin.petersen@...cle.com, _govind@....com, kabel@...nel.org, viresh.kumar@...aro.org, Tushar.Khandelwal@....com, kuba@...nel.org Subject: Re: [PATCH v5 11/14] scsi: lpfc: Use irq_set_affinity On 7/20/2021 4:26 PM, Nitesh Narayan Lal wrote: > The driver uses irq_set_affinity_hint to set the affinity for the lpfc > interrupts to a mask corresponding to the local NUMA node to avoid > performance overhead on AMD architectures. > > However, irq_set_affinity_hint() setting the affinity is an undocumented > side effect that this function also sets the affinity under the hood. > To remove this side effect irq_set_affinity_hint() has been marked as > deprecated and new interfaces have been introduced. > > Also, as per the commit dcaa21367938 ("scsi: lpfc: Change default IRQ model > on AMD architectures"): > "On AMD architecture, revert the irq allocation to the normal style > (non-managed) and then use irq_set_affinity_hint() to set the cpu affinity > and disable user-space rebalancing." > we don't really need to set the affinity_hint as user-space rebalancing for > the lpfc interrupts is not desired. > > Hence, replace the irq_set_affinity_hint() with irq_set_affinity() which > only applies the affinity for the interrupts. > > Signed-off-by: Nitesh Narayan Lal <nitesh@...hat.com> > --- > drivers/scsi/lpfc/lpfc_init.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Looks good. Thanks Reviewed-by: James Smart <jsmart2021@...il.com> -- james
Powered by blists - more mailing lists