linux-kernel - [PATCH] is_core_idle() is using a wrong variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210722063946.28951-1-mika.penttila@gmail.com>
Date:   Thu, 22 Jul 2021 09:39:46 +0300
From:   mika.penttila@...il.com
To:     linux-kernel@...r.kernel.org
Cc:     lirongqing@...du.com, pbonzini@...hat.com, mingo@...hat.com,
        peterz@...radead.org, kvm@...r.kernel.org,
        Mika Penttilä <mika.penttila@...il.com>
Subject: [PATCH] is_core_idle() is using a wrong variable

From: Mika Penttilä <mika.penttila@...il.com>

is_core_idle() was using a wrong variable in the loop test. Fix it.

Signed-off-by: Mika Penttilä <mika.penttila@...il.com>
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 44c452072a1b..30a6984a58f7 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1486,7 +1486,7 @@ static inline bool is_core_idle(int cpu)
 		if (cpu == sibling)
 			continue;
 
-		if (!idle_cpu(cpu))
+		if (!idle_cpu(sibling))
 			return false;
 	}
 #endif
-- 
2.17.1