linux-kernel - Re: [PATCH v1 1/1] serial: max310x: Use clock-names property matching to recognize XTAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Jul 2021 18:45:40 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Jiri Slaby <jirislaby@...nel.org>, Dennis Giaya <dgiaya@...i.edu>
Subject: Re: [PATCH v1 1/1] serial: max310x: Use clock-names property
 matching to recognize XTAL

On Thu, Jul 22, 2021 at 06:02:33PM +0300, Andy Shevchenko wrote:
> Dennis reported that on ACPI-based systems the clock frequency
> isn't enough to configure device properly. We have to respect
> the clock source as well. To achieve this match the clock-names
> property against "xtal" to recognize crystal connection.

Dennis, please test this.

...

> -	s->clk = devm_clk_get_optional(dev, "osc");
> +	xtal = device_property_match_string(dev, "clock-names", "xtal") >= 0;

Meanwhile I will change this (not affects the testing in your case) to actually
negative one as:

	..., "osc") < 0;

to be compatible with the original flow (in case there are two clock names, the
"osc" has a priority).


-- 
With Best Regards,
Andy Shevchenko