linux-kernel - Re: [PATCH v1 1/1] serial: max310x: Use clock-names property matching to recognize XTAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0acef8aa86d69cac0ea1a3dbdafc41625580e0eb.camel@whoi.edu>
Date:   Thu, 22 Jul 2021 21:05:13 +0000
From:   Dennis Giaya <dgiaya@...i.edu>
To:     "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "jirislaby@...nel.org" <jirislaby@...nel.org>
Subject: Re: [PATCH v1 1/1] serial: max310x: Use clock-names property matching
 to recognize XTAL

Andy,

I've tested this out on my hardware that uses an external oscillator
'osc' (as opposed to external crystal 'xtal').

With the relevant asl
	Package () {"compatible", "maxim,max14830"},
	Package ()
{"clock-frequency", 19200000},
	Package () {"clock-names", "osc"},

Previously, the driver logic would default to 'xtal' and then compare
against the narrower frequency range and throw an error because 19.2MHz
was not allowed. With your patch, it proceeds as 'osc' and appears to
work as intended.

Thanks!
Dennis


On Thu, 2021-07-22 at 18:45 +0300, Andy Shevchenko wrote:
> On Thu, Jul 22, 2021 at 06:02:33PM +0300, Andy Shevchenko wrote:
> > Dennis reported that on ACPI-based systems the clock frequency
> > isn't enough to configure device properly. We have to respect
> > the clock source as well. To achieve this match the clock-names
> > property against "xtal" to recognize crystal connection.
> 
> Dennis, please test this.
> 
> ...
> 
> > -	s->clk = devm_clk_get_optional(dev, "osc");
> > +	xtal = device_property_match_string(dev, "clock-names", "xtal")
> > >= 0;
> 
> Meanwhile I will change this (not affects the testing in your case)
> to actually
> negative one as:
> 
> 	..., "osc") < 0;
> 
> to be compatible with the original flow (in case there are two clock
> names, the
> "osc" has a priority).
> 
> 

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5624 bytes)