linux-kernel - RE: [PATCH 2/2] PCI: vmd: Make use of PCI_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a13ed0d8b1c4eb2bea2e10e982c2ed1@baidu.com>
Date:   Fri, 23 Jul 2021 03:28:01 +0000
From:   "Cai,Huoqing" <caihuoqing@...du.com>
To:     Krzysztof Wilczyński <kw@...ux.com>
CC:     "Derrick, Jonathan" <jonathan.derrick@...el.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] PCI: vmd: Make use of PCI_DEVICE_DATA() helper
 function

Hi,

 	Thank for your suggestion, useful to me
I will send PATCH v3 again with changelog :

v1->v2: *fix  extra indent which occurs git-apply error

v2->v3:  *update the subject line from "funtion" to "macro"
	 *add changelog to commit message

commit date: 7-23-2021 11:00

thx

-----Original Message-----
From: Krzysztof Wilczyński <kw@...ux.com> 
Sent: 2021年7月23日 10:00
To: Cai,Huoqing <caihuoqing@...du.com>
Cc: Derrick, Jonathan <jonathan.derrick@...el.com>; linux-pci@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] PCI: vmd: Make use of PCI_DEVICE_DATA() helper function

Hi,

Thank you for sending the patch over!

> 	PATCH[2/2] has some extra indentation, please don't apply it ,

You might know this already, but just in case make sure to run the "checkpatch.pl" script over the patch before submission.

> I'll send PATCH V2.

You mean v3?  Make sure to include a changelog, if possible.

A small nitpick: the PCI_DEVICE_DATA() is technically a macro rather than a function, so you could update both the subject line and the commit message accordingly, if you want.

Also, since you are about to send another version, add period at the end of the sentence in the commit message.

Aside of the above, it's a nice refactor, thank you!

	Krzysztof