linux-kernel - Re: [PATCH 2/2] PCI: vmd: Make use of PCI_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210723020013.GA2170028@rocinante>
Date:   Fri, 23 Jul 2021 04:00:13 +0200
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     "Cai,Huoqing" <caihuoqing@...du.com>
Cc:     "Derrick, Jonathan" <jonathan.derrick@...el.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] PCI: vmd: Make use of PCI_DEVICE_DATA() helper
 function

Hi,

Thank you for sending the patch over!

> 	PATCH[2/2] has some extra indentation, please don't apply it , 

You might know this already, but just in case make sure to run the
"checkpatch.pl" script over the patch before submission.

> I'll send PATCH V2.

You mean v3?  Make sure to include a changelog, if possible.

A small nitpick: the PCI_DEVICE_DATA() is technically a macro rather
than a function, so you could update both the subject line and the
commit message accordingly, if you want.

Also, since you are about to send another version, add period at the end
of the sentence in the commit message.

Aside of the above, it's a nice refactor, thank you!

	Krzysztof