linux-kernel - Re: [PATCH v11 1/4] dt-bindings: PCI: mediatek: Update the Device tree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Jul 2021 15:17:26 +0800
From:   Chuanjia Liu <chuanjia.liu@...iatek.com>
To:     Rob Herring <robh@...nel.org>
CC:     Matthias Brugger <matthias.bgg@...il.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jianjun Wang <jianjun.wang@...iatek.com>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Ryder Lee <ryder.lee@...iatek.com>,
        PCI <linux-pci@...r.kernel.org>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        <devicetree@...r.kernel.org>, Yong Wu <yong.wu@...iatek.com>
Subject: Re: [PATCH v11 1/4] dt-bindings: PCI: mediatek: Update the Device
 tree bindings

On Tue, 2021-07-20 at 10:26 -0600, Rob Herring wrote:
> On Mon, Jul 19, 2021 at 8:07 PM Chuanjia Liu <chuanjia.liu@...iatek.com> wrote:
> >
> > On Mon, 2021-07-19 at 16:47 -0600, Rob Herring wrote:
> > > On Mon, 19 Jul 2021 15:34:53 +0800, Chuanjia Liu wrote:
> > > > There are two independent PCIe controllers in MT2712 and MT7622
> > > > platform. Each of them should contain an independent MSI domain.
> > > >
> > > > In old dts architecture, MSI domain will be inherited from the root
> > > > bridge, and all of the devices will share the same MSI domain.
> > > > Hence that, the PCIe devices will not work properly if the irq number
> > > > which required is more than 32.
> > > >
> > > > Split the PCIe node for MT2712 and MT7622 platform to comply with
> > > > the hardware design and fix MSI issue.
> > > >
> > > > Signed-off-by: Chuanjia Liu <chuanjia.liu@...iatek.com>
> > > > Acked-by: Ryder Lee <ryder.lee@...iatek.com>
> > > > ---
> > > >  .../bindings/pci/mediatek-pcie-cfg.yaml       |  39 ++++
> > > >  .../devicetree/bindings/pci/mediatek-pcie.txt | 206 ++++++++++--------
> > > >  2 files changed, 150 insertions(+), 95 deletions(-)
> > > >  create mode 100644 Documentation/devicetree/bindings/pci/mediatek-pcie-cfg.yaml
> > > >
> > >
> > >
> > > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> > > there's no need to repost patches *only* to add the tags. The upstream
> > > maintainer will do that for acks received on the version they apply.
> > >
> > > If a tag was not added on purpose, please state why and what changed.
> > >
> > Hi,Rob
> > I have described in the cover letter:
> > v11:Rebase for 5.14-rc1 and add "interrupt-names", "linux,pci-domain"
> >     description in binding file. No code change.
> > if you still ok for this, I will add R-b in next version.
> 
> Yes, it's fine.
> 
> In the future, put the changelog for a patch in the patch.
Hi, Rob
 Thanks for you suggestion, I will do this in future versions.
Best regards