linux-kernel - Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEsQvcs3P+TqQFzQetPfRycpo66eJFwnzwhk2JyCXFaCLFHmFg@mail.gmail.com>
Date:   Sat, 24 Jul 2021 15:04:13 +0000
From:   Geraldo Nascimento <geraldogabriel@...il.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     chihhao.chen@...iatek.com, alsa-devel@...a-project.org,
        wsd_upstream@...iatek.com, damien@...audio.com, tiwai@...e.com,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        matthias.bgg@...il.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting

On Sat, Jul 24, 2021 at 8:05 AM Takashi Iwai <tiwai@...e.de> wrote:
>
> This looks like a regression introduced by the recent commit
> d2e8f641257d ("ALSA: usb-audio: Explicitly set up the clock
> selector"), which is a fix for certain devices.  Too bad that the
> behavior really depends on the device...

Dr. Iwai, perhaps we could restrict the generalized fix for the
Behringer UFX1604 / UFX1204 with some simple logic to devices that
only have *one* clock source.

In that case the clock selector must be set to the only clock source.

This way we keep the generalization without breaking devices with more
than one clock source.

Just an idea.

Thank you,
Geraldo Nascimento