linux-kernel - Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h7dhgi1e2.wl-tiwai@suse.de>
Date:   Sat, 24 Jul 2021 10:04:05 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     <chihhao.chen@...iatek.com>
Cc:     <linux-mediatek@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <alsa-devel@...a-project.org>,
        <damien@...audio.com>, <perex@...ex.cz>, <tiwai@...e.com>,
        <matthias.bgg@...il.com>, <wsd_upstream@...iatek.com>
Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting

On Sat, 24 Jul 2021 06:23:41 +0200,
<chihhao.chen@...iatek.com> wrote:
> 
> From: "chihhao.chen" <chihhao.chen@...iatek.com>
> 
> The following scenario describes an echo test for
> Samsung USBC Headset (AKG) with VID/PID (0x04e8/0xa051).
> 
> We first start a capture stream(USB IN transfer) in 96Khz/24bit/1ch mode.
> In clock find source function, we get value 0x2 for clock selector
> and 0x1 for clock source.
> 
> Kernel-4.14 behavior
> Since clock source is valid so clock selector was not set again.
> We pass through this function and start a playback stream(USB OUT transfer)
> in 48Khz/32bit/2ch mode. This time we get value 0x1 for clock selector
> and 0x1 for clock source. Finally clock id with this setting is 0x9.
> 
> Kernel-5.10 behavior
> Clock selector was always set one more time even it is valid.
> When we start a playback stream, we will get 0x2 for clock selector
> and 0x1 for clock source. In this case clock id becomes 0xA.
> This is an incorrect clock source setting and results in severe noises.
> We see wrong data rate in USB IN transfer.
> (From 288 bytes/ms becomes 144 bytes/ms) It should keep in 288 bytes/ms.
> 
> This earphone works fine on older kernel version load because
> this is a newly-added behavior.
> 
> Signed-off-by: chihhao.chen <chihhao.chen@...iatek.com>

Thanks for the patch.

This looks like a regression introduced by the recent commit
d2e8f641257d ("ALSA: usb-audio: Explicitly set up the clock
selector"), which is a fix for certain devices.  Too bad that the
behavior really depends on the device...

Maybe we need to introduce some flag to handle this commonly, but for
now, let's take the fix as is.


Takashi