linux-kernel - Re: [PATCH] misc: powermate: update the reference count of the usb interface structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YPydUp9vc5U7vGIw@google.com>
Date:   Sat, 24 Jul 2021 16:08:02 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Salah Triki <salah.triki@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: powermate: update the reference count of the usb
 interface structure

Hi,

On Sat, Jul 24, 2021 at 10:20:16PM +0100, Salah Triki wrote:
> Use usb_get_intf() and usb_put_intf() in order to update the reference
> count of the usb interface structure.

This is quite pointless as the driver will be unbound from the interface
before interface is deleted.

> 
> Signed-off-by: Salah Triki <salah.triki@...il.com>
> ---
>  drivers/input/misc/powermate.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/misc/powermate.c b/drivers/input/misc/powermate.c
> index c4e0e1886061..69dc3347478a 100644
> --- a/drivers/input/misc/powermate.c
> +++ b/drivers/input/misc/powermate.c
> @@ -337,7 +337,7 @@ static int powermate_probe(struct usb_interface *intf, const struct usb_device_i
>  		goto fail3;
>  
>  	pm->udev = udev;
> -	pm->intf = intf;
> +	pm->intf = usb_get_intf(intf);
>  	pm->input = input_dev;
>  
>  	usb_make_path(udev, pm->phys, sizeof(pm->phys));
> @@ -428,6 +428,7 @@ static void powermate_disconnect(struct usb_interface *intf)
>  		usb_free_urb(pm->irq);
>  		usb_free_urb(pm->config);
>  		powermate_free_buffers(interface_to_usbdev(intf), pm);
> +		usb_put_intf(pm->intf);
>  
>  		kfree(pm);
>  	}
> -- 
> 2.25.1
> 

Thanks.

-- 
Dmitry