linux-kernel - Re: [PATCH] misc: powermate: update the reference count of the usb interface structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210724235637.GA590874@pc>
Date:   Sun, 25 Jul 2021 00:56:37 +0100
From:   Salah Triki <salah.triki@...il.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: powermate: update the reference count of the usb
 interface structure

Hi,

On Sat, Jul 24, 2021 at 04:08:02PM -0700, Dmitry Torokhov wrote:
> 
> On Sat, Jul 24, 2021 at 10:20:16PM +0100, Salah Triki wrote:
> > Use usb_get_intf() and usb_put_intf() in order to update the reference
> > count of the usb interface structure.
> 
> This is quite pointless as the driver will be unbound from the interface
> before interface is deleted.

>From the documentation of usb_get_intf():

[quote]

Each live reference to a interface must be refcounted.

Drivers for USB interfaces should normally record such references in their 
probe() methods, when they bind to an interface, and release them by calling
usb_put_intf(), in their disconnect() methods.

[/quote]

Thanx