linux-kernel - Re: [PATCH] staging: android: Remove set but unused variable in ashmem.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210726134454.GJ1931@kadam>
Date:   Mon, 26 Jul 2021 16:44:54 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Suren Baghdasaryan <surenb@...gle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>,
        Martijn Coenen <maco@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Christian Brauner <christian@...uner.io>,
        Hridya Valsaraju <hridya@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: android: Remove set but unused variable in
 ashmem.c

On Sat, Jul 24, 2021 at 09:49:35AM +0200, Fabio M. De Francesco wrote:
> On Friday, July 23, 2021 10:14:46 PM CEST Suren Baghdasaryan wrote:
> > How about its usage in the above lockdep_set_class(&inode->i_rwsem,
> > ...) call? 
> 
> I'm sorry. I didn't notice that 'inode' is used soon after assignment, just in 
> the line that follows it. I was also too confident that rebuilding the driver 
> would have triggered an error if it is used somewhere else. I was obviously 
> wrong.
> 
> Furthermore, I usually automatically search with grep or other tools for other 
> occurrences of a symbol in the function and the file, but this time I must 
> have forgotten to do that.

Another trick which would have helped is to try find out which patch
forgot to remove the "inode" variale, because that developer would have
seen the warning as well.


> 
> > I'm guessing you are building with CONFIG_LOCKDEP=n.
> 
> Actually my .config sets CONFIG_LOCKDEP_SUPPORT=y. Did you refer to this? 
> There is no CONFIG_LOCKDEP in the file.

Use make nconfig and then use f8 to search for CONFIG_LOCKDEP.

regards,
dan carpenter