linux-kernel - Re: [PATCH] staging: android: Remove set but unused variable in ashmem.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4425350.seJdf4cM5h@localhost.localdomain>
Date:   Wed, 28 Jul 2021 14:00:19 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Suren Baghdasaryan <surenb@...gle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>,
        Martijn Coenen <maco@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Christian Brauner <christian@...uner.io>,
        Hridya Valsaraju <hridya@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: android: Remove set but unused variable in ashmem.c

Hello Dan,

On Monday, July 26, 2021 3:44:54 PM CEST Dan Carpenter wrote:
> On Sat, Jul 24, 2021 at 09:49:35AM +0200, Fabio M. De Francesco wrote:
> >
> > [...]
> >
> Another trick which would have helped is to try find out which patch
> forgot to remove the "inode" variable, because that developer would have
> seen the warning as well.
> 
> > > I'm guessing you are building with CONFIG_LOCKDEP=n.
> > 
> > Actually my .config sets CONFIG_LOCKDEP_SUPPORT=y. Did you refer to this?
> > There is no CONFIG_LOCKDEP in the file.
> 
> Use make nconfig and then use f8 to search for CONFIG_LOCKDEP.
> 
> regards,
> dan carpenter

Thanks a lot. As always, you've been very helpful. I appreciate your 
willingness to help and, more generally, your attitude towards people with 
less experience than yours.

By using F8, I found that CONFIG_LOCKDEP is selected by CONFIG_LOCK_STAT (in 
logical AND with other options) but, in my .config, the latter was set to 'n'. 
After setting this other option to 'y', CONFIG_LOCKDEP magically :) appeared  
in .config and it was automatically set to 'y'.

I see that the same kind of search can also be done by using the slash if one 
uses "make menuconfig".

Regards,

Fabio