linux-kernel - Re: [PATCH V2] media: uvcvideo: Remove unused including <linux/version.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc520c2d-a314-fc58-35f9-07564401b4a9@infradead.org>
Date:   Tue, 27 Jul 2021 13:50:25 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Cai Huoqing <caihuoqing@...du.com>,
        laurent.pinchart@...asonboard.com, mchehab@...nel.org,
        thierry.reding@...il.com, jonathanh@...dia.com
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH V2] media: uvcvideo: Remove unused including
 <linux/version.h>

On 7/27/21 2:28 AM, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it.
> 
> V1->V2: Split the patch in two.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>

as reported by 'make versioncheck':

../drivers/media/usb/uvc/uvc_driver.c: 19 linux/version.h not needed.

Acked-by: Randy Dunlap <rdunlap@...radead.org>

thanks.

> ---
>  drivers/media/usb/uvc/uvc_driver.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 9a791d8ef200..b1b055784f8d 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -16,7 +16,6 @@
>  #include <linux/videodev2.h>
>  #include <linux/vmalloc.h>
>  #include <linux/wait.h>
> -#include <linux/version.h>
>  #include <asm/unaligned.h>
>  
>  #include <media/v4l2-common.h>
> 


-- 
~Randy