linux-kernel - Re: [PATCH] media: s3c-camif: Remove unused including <linux/version.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e09e8157-ff37-ba76-49a8-c6c2f84725b4@infradead.org>
Date:   Tue, 27 Jul 2021 13:52:06 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Cai Huoqing <caihuoqing@...du.com>, sylvester.nawrocki@...il.com,
        mchehab@...nel.org
Cc:     linux-media@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: s3c-camif: Remove unused including
 <linux/version.h>

On 7/26/21 10:40 PM, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>

as reported by 'make versioncheck':

../drivers/media/platform/s3c-camif/camif-core.c: 26 linux/version.h not needed.

Acked-by: Randy Dunlap <rdunlap@...radead.org>

thanks.

> ---
>  drivers/media/platform/s3c-camif/camif-core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/platform/s3c-camif/camif-core.c b/drivers/media/platform/s3c-camif/camif-core.c
> index e1d51fd3e700..64078cbfd7f9 100644
> --- a/drivers/media/platform/s3c-camif/camif-core.c
> +++ b/drivers/media/platform/s3c-camif/camif-core.c
> @@ -23,7 +23,6 @@
>  #include <linux/pm_runtime.h>
>  #include <linux/slab.h>
>  #include <linux/types.h>
> -#include <linux/version.h>
>  
>  #include <media/media-device.h>
>  #include <media/v4l2-ctrls.h>
> 


-- 
~Randy