linux-kernel - Re: [PATCH cgroup/for-5.14-fixes] cgroup: rstat: fix A-A deadlock on 32bit around u64_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YQCTEYhcxKccOamq@slm.duckdns.org>
Date:   Tue, 27 Jul 2021 13:13:21 -1000
From:   Tejun Heo <tj@...nel.org>
To:     cgroups@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Rik van Riel <riel@...riel.com>
Subject: Re: [PATCH cgroup/for-5.14-fixes] cgroup: rstat: fix A-A deadlock on
 32bit around u64_stats_sync

On Tue, Jul 27, 2021 at 01:04:49PM -1000, Tejun Heo wrote:
> 0fa294fb1985 ("cgroup: Replace cgroup_rstat_mutex with a spinlock") added
> cgroup_rstat_flush_irqsafe() allowing flushing to happen from the irq
> context. However, rstat paths use u64_stats_sync to synchronize access to
> 64bit stat counters on 32bit machines. u64_stats_sync is implemented using
> seq_lock and trying to read from an irq context can lead to A-A deadlock if
> the irq happens to interrupt the stat update.
> 
> Fix it by using the irqsafe variants - u64_stats_update_begin_irqsave() and
> u64_stats_update_end_irqrestore() - in the update paths. Note that none of
> this matters on 64bit machines. All these are just for 32bit SMP setups.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Reported-by: Rik van Riel <riel@...riel.com>

Applying this to cgroup/for-5.14-fixes with stable tag added.

Thanks.

-- 
tejun