linux-kernel - Re: [PATCH 2/2] perf annotate: Add error log in symbol_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YQAsbprd0sl7gya4@kernel.org>
Date:   Tue, 27 Jul 2021 12:55:26 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     James Clark <james.clark@....com>
Cc:     Li Huafei <lihuafei1@...wei.com>, jolsa@...nel.org,
        peterz@...radead.org, mark.rutland@....com, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, namhyung@...nel.org,
        mliska@...e.cz, irogers@...gle.com, dzhu@...ecomp.com,
        rickyman7@...il.com, yao.jin@...ux.intel.com,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhangjinhao2@...wei.com
Subject: Re: [PATCH 2/2] perf annotate: Add error log in symbol__annotate()

Em Mon, Jul 26, 2021 at 04:19:26PM +0100, James Clark escreveu:
> 
> 
> On 26/07/2021 13:38, Li Huafei wrote:
> > When users use the perf annotate feature on unsupported machines, error
> > logs should be printed for user feedback.
> > 
> > Signed-off-by: Li Huafei <lihuafei1@...wei.com>
> > ---
> >  tools/perf/util/annotate.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> > index aa04a3655236..cb280de3369f 100644
> > --- a/tools/perf/util/annotate.c
> > +++ b/tools/perf/util/annotate.c
> > @@ -2192,8 +2192,10 @@ int symbol__annotate(struct map_symbol *ms, struct evsel *evsel,
> >  		return errno;
> >  
> >  	args.arch = arch = arch__find(arch_name);
> > -	if (arch == NULL)
> > +	if (arch == NULL) {
> > +		pr_err("%s: unsupported arch %s\n", __func__, arch_name);
> >  		return ENOTSUP;
> > +	}
> >  
> >  	if (parch)
> >  		*parch = arch;
> > 
> 
> This one is missing the v2 in the summary so it doesn't work with tools like b4,
> but I applied it manually and it works.
> 
> Reviewed-by: James Clark <james.clark@....com>

Thanks, applied.

- Arnaldo