linux-kernel - Re: [PATCH v1 1/1] lib/test_scanf: Handle n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db516512-2f52-9526-f5f5-0571061c5990@opensource.cirrus.com>
Date:   Tue, 27 Jul 2021 16:27:37 +0100
From:   Richard Fitzgerald <rf@...nsource.cirrus.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Petr Mladek <pmladek@...e.com>, <linux-kernel@...r.kernel.org>
CC:     Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        kernel test robot <oliver.sang@...el.com>
Subject: Re: [PATCH v1 1/1] lib/test_scanf: Handle n_bits == 0 in random tests

On 27/07/2021 16:01, Andy Shevchenko wrote:
> UBSAN reported (via LKP)
> 
> [   11.021349][    T1] UBSAN: shift-out-of-bounds in lib/test_scanf.c:275:51
> [   11.022782][    T1] shift exponent 32 is too large for 32-bit type 'unsigned int'
> 
> When n_bits == 0, the shift is out of range. Switch code to use GENMASK
> to handle this case.
> 
> Fixes: 50f530e176ea ("lib: test_scanf: Add tests for sscanf number conversion")
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---

Reviewed-by: Richard Fitzgerald <rf@...nsource.cirrus.com>

Sorry about that. Would have been sensible to use GENMASK anyway.