linux-kernel - Re: [PATCH] is_core_idle() is using a wrong variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210728115006.GC3809@techsingularity.net>
Date:   Wed, 28 Jul 2021 12:50:06 +0100
From:   Mel Gorman <mgorman@...hsingularity.net>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     mika.penttila@...il.com, linux-kernel@...r.kernel.org,
        lirongqing@...du.com, pbonzini@...hat.com, mingo@...hat.com,
        kvm@...r.kernel.org, Mel Gorman <mgorman@...e.de>
Subject: Re: [PATCH] is_core_idle() is using a wrong variable

On Wed, Jul 28, 2021 at 12:41:03PM +0200, Peter Zijlstra wrote:
> On Thu, Jul 22, 2021 at 09:39:46AM +0300, mika.penttila@...il.com wrote:
> > From: Mika Penttilä <mika.penttila@...il.com>
> > 
> > is_core_idle() was using a wrong variable in the loop test. Fix it.
> > 
> > Signed-off-by: Mika Penttilä <mika.penttila@...il.com>
> 
> Thanks!
> 
> ---
> Subject: sched/numa: Fix is_core_idle()
> From: Mika Penttilä <mika.penttila@...il.com>
> Date: Thu, 22 Jul 2021 09:39:46 +0300
> 
> From: Mika Penttilä <mika.penttila@...il.com>
> 
> Use the loop variable instead of the function argument to test the
> other SMT siblings for idle.
> 
> Fixes: ff7db0bf24db ("sched/numa: Prefer using an idle CPU as a migration target instead of comparing tasks")
> Signed-off-by: Mika Penttilä <mika.penttila@...il.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> Link: https://lkml.kernel.org/r/20210722063946.28951-1-mika.penttila@gmail.com

Acked-by: Mel Gorman <mgorman@...hsingularity.net>

-- 
Mel Gorman
SUSE Labs