linux-kernel - Re: [PATCH -next] filesystems/locking: fix Malformed table warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210728132044.GH29619@quack2.suse.cz>
Date:   Wed, 28 Jul 2021 15:20:44 +0200
From:   Jan Kara <jack@...e.cz>
To:     "Darrick J. Wong" <djwong@...nel.org>
Cc:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org,
        Christoph Hellwig <hch@....de>, Jan Kara <jack@...e.cz>,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH -next] filesystems/locking: fix Malformed table warning

On Tue 27-07-21 17:04:09, Darrick J. Wong wrote:
> On Tue, Jul 27, 2021 at 04:22:12PM -0700, Randy Dunlap wrote:
> > Update the bottom border to be the same as the top border.
> > 
> > Documentation/filesystems/locking.rst:274: WARNING: Malformed table.
> > Bottom/header table border does not match top border.
> > 
> > Fixes: 730633f0b7f9 ("mm: Protect operations adding pages to page cache with invalidate_lock")
> > Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> > Cc: Darrick J. Wong <djwong@...nel.org>
> > Cc: Christoph Hellwig <hch@....de>
> > Cc: Jan Kara <jack@...e.cz>
> > Cc: linux-fsdevel@...r.kernel.org
> 
> Looks ugly but probably correct
> Reviewed-by: Darrick J. Wong <djwong@...nel.org>

Thanks for the fix and for review! I've added the patch to my branch with
hole punch fixes.

								Honza
> > ---
> >  Documentation/filesystems/locking.rst |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- linext-20210727.orig/Documentation/filesystems/locking.rst
> > +++ linext-20210727/Documentation/filesystems/locking.rst
> > @@ -295,7 +295,7 @@ is_partially_uptodate:	yes
> >  error_remove_page:	yes
> >  swap_activate:		no
> >  swap_deactivate:	no
> > -======================	======================== =========
> > +======================	======================== =========	===============
> >  
> >  ->write_begin(), ->write_end() and ->readpage() may be called from
> >  the request handler (/dev/loop).
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR