linux-kernel - Re: [PATCH] can: flexcan: Fix an uninitialized variable issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210729114442.GT1931@kadam>
Date:   Thu, 29 Jul 2021 14:44:42 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        wg@...ndegger.com, davem@...emloft.net, kuba@...nel.org,
        angelo@...nel-space.org, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] can: flexcan: Fix an uninitialized variable issue

On Thu, Jul 29, 2021 at 01:31:01PM +0200, Marc Kleine-Budde wrote:
> On 29.07.2021 13:27:42, Christophe JAILLET wrote:
> > If both 'clk_ipg' and 'clk_per' are NULL, we return an un-init value.
> > So set 'err' to 0, to return success in such a case.
> 
> Thanks for the patch, a similar one has been posted before:
> https://lore.kernel.org/linux-can/20210728075428.1493568-1-mkl@pengutronix.de/
> 
> > Fixes: d9cead75b1c6 ("can: flexcan: add mcf5441x support")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> > ---
> > Another way to fix it is to remove the NULL checks for 'clk_ipg' and
> > 'clk_per' that been added in commit d9cead75b1c6.
> > 
> > They look useless to me because 'clk_prepare_enable()' returns 0 if it is
> > passed a NULL pointer.
> 
> ACK, while the common clock framework's clk_prepare_enable() can handle
> NULL pointers, the clock framework used on the mcf5441x doesn't.

Huh?  It looks like it just uses the regular stuff?

regards,
dan carpenter