linux-kernel - Re: [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d687d5f-d514-655a-f8bf-a5bac321affb@lwfinger.net>
Date:   Thu, 29 Jul 2021 11:47:45 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Martin Kaiser <martin@...ser.cx>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Greg KH <gregkh@...uxfoundation.org>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-staging@...ts.linux.dev, Fabio Aiuto <fabioaiuto83@...il.com>
Subject: Re: [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu
 driver

On 7/29/21 8:37 AM, Martin Kaiser wrote:
> ok, understood. That's an important feature. I see that Greg accepted
> your patches, there's no point in arguing any more;-)
> 
> Greg and Larry: Would you mind sharing your ideas about getting
> rtl8188eu support mainline? Do you imagine that we clean up this driver
> until it can be moved out of staging? If so, we'd probably have to
> resolve name conflicts with other realtek drivers and rename lots of
> functions. Or would a cleanup of the new rtl8188eu driver be a
> preparation for adding bits and pieces of it to rtlwifi?

Martin,

I do see this driver being cleaned up to the point that it transitions to mainline.

It is not clear to me that it would fit into the rtlwifi framework. It probably 
could use the USB driver there, but unlikely to use a lot more of that code.

I will certainly be on the lookout for conflicts with the rtlwifi and rtl8xxxu, 
indeed the whole drivers/net/wireless/realtek/, code as the cleanup proceeds.

Thanks for your concerns and questions.

Larry