linux-kernel - Re: [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210801175049.eubghjzmhx25ol73@viti.kaiser.cx>
Date:   Sun, 1 Aug 2021 19:50:49 +0200
From:   Martin Kaiser <martin@...ser.cx>
To:     Larry Finger <Larry.Finger@...inger.net>
Cc:     Phillip Potter <phil@...lpotter.co.uk>,
        Greg KH <gregkh@...uxfoundation.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-staging@...ts.linux.dev, Fabio Aiuto <fabioaiuto83@...il.com>
Subject: Re: [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu
 driver

Hello Greg and Larry,

thanks for your responses.

Thus wrote Larry Finger (Larry.Finger@...inger.net):

> I do see this driver being cleaned up to the point that it transitions to mainline.

> It is not clear to me that it would fit into the rtlwifi framework. It
> probably could use the USB driver there, but unlikely to use a lot more of
> that code.

Ok, that clarifies that path forward. I wasn't sure if a standalone
(non-rtlwifi) driver is acceptable at all.

> I will certainly be on the lookout for conflicts with the rtlwifi and
> rtl8xxxu, indeed the whole drivers/net/wireless/realtek/, code as the
> cleanup proceeds.

At the moment, the driver (like the old one) can be compiled only as a
module. I guess that's because of name conflicts between realtek drivers
that originated from the same codebase. It seems that we'll have to
rename some functions along the way.

Thanks,
Martin