linux-kernel - Re: [PATCH] mm: delete unused get_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YQOqwnu7ewZldkUN@infradead.org>
Date:   Fri, 30 Jul 2021 08:31:14 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     John Hubbard <jhubbard@...dia.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org,
        Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
        Christoph Hellwig <hch@...radead.org>,
        "David S . Miller" <davem@...emloft.net>,
        Eric B Munson <emunson@...bm.net>,
        Eric Paris <eparis@...hat.com>,
        James Morris <jmorris@...ei.org>,
        Mike Christie <michaelc@...wisc.edu>,
        Neil Brown <neilb@...e.de>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Sebastian Andrzej Siewior <sebastian@...akpoint.cc>,
        Trond Myklebust <Trond.Myklebust@...app.com>,
        Xiaotian Feng <dfeng@...hat.com>,
        Mark Salter <msalter@...hat.com>
Subject: Re: [PATCH] mm: delete unused get_kernel_page()

On Thu, Jul 29, 2021 at 03:18:47PM -0700, John Hubbard wrote:
> get_kernel_page() was added in 2012 by [1]. It was used for a while for
> NFS, but then in 2014, a refactoring [2] removed all callers, and it has
> apparently not been used since.

Looks good, pinnining by kernel virtual address doesn't really make
much sense.

Reviewed-by: Christoph Hellwig <hch@....de>