linux-kernel - Re: [PATCH] mm: delete unused get_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3551cde6-b48f-8cfc-7b64-b3341e717716@redhat.com>
Date:   Fri, 30 Jul 2021 11:17:21 +0200
From:   David Hildenbrand <david@...hat.com>
To:     John Hubbard <jhubbard@...dia.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org,
        Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
        Christoph Hellwig <hch@...radead.org>,
        "David S . Miller" <davem@...emloft.net>,
        Eric B Munson <emunson@...bm.net>,
        Eric Paris <eparis@...hat.com>,
        James Morris <jmorris@...ei.org>,
        Mike Christie <michaelc@...wisc.edu>,
        Neil Brown <neilb@...e.de>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Sebastian Andrzej Siewior <sebastian@...akpoint.cc>,
        Trond Myklebust <Trond.Myklebust@...app.com>,
        Xiaotian Feng <dfeng@...hat.com>,
        Mark Salter <msalter@...hat.com>
Subject: Re: [PATCH] mm: delete unused get_kernel_page()

On 30.07.21 00:18, John Hubbard wrote:
> get_kernel_page() was added in 2012 by [1]. It was used for a while for
> NFS, but then in 2014, a refactoring [2] removed all callers, and it has
> apparently not been used since.
> 
> Remove get_kernel_page() because it has no callers.
> 
> [1] commit 18022c5d8627 ("mm: add get_kernel_page[s] for pinning of
>      kernel addresses for I/O")
> [2] commit 91f79c43d1b5 ("new helper: iov_iter_get_pages_alloc()")
> 
> Cc: Mel Gorman <mgorman@...e.de>
> Cc: Rik van Riel <riel@...hat.com>
> Cc: Christoph Hellwig <hch@...radead.org>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Eric B Munson <emunson@...bm.net>
> Cc: Eric Paris <eparis@...hat.com>
> Cc: James Morris <jmorris@...ei.org>
> Cc: Mike Christie <michaelc@...wisc.edu>
> Cc: Neil Brown <neilb@...e.de>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
> Cc: Trond Myklebust <Trond.Myklebust@...app.com>
> Cc: Xiaotian Feng <dfeng@...hat.com>
> Cc: Mark Salter <msalter@...hat.com>
> Signed-off-by: John Hubbard <jhubbard@...dia.com>
> ---
> 
> Hi,
> 
> Just a minor decluttering: I ran across this while looking for something
> else entirely, and then noticed that it's been orphaned for quite a long
> time. It seems like only the plural form of this function is needed
> these days, and probably in the coming days as well.
> 
> thanks,
> John Hubbard
> NVIDIA

Reviewed-by: David Hildenbrand <david@...hat.com>


-- 
Thanks,

David / dhildenb