linux-kernel - [PATCH] xtensa: ISS: Fix warning comparing pointer to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1627640999-17706-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Date:   Fri, 30 Jul 2021 18:29:59 +0800
From:   Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
To:     chris@...kel.net
Cc:     jcmvbkbc@...il.com, linux-xtensa@...ux-xtensa.org,
        linux-kernel@...r.kernel.org,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Subject: [PATCH] xtensa: ISS: Fix warning comparing pointer to 0

Fix the following coccicheck warning:

./arch/xtensa/platforms/iss/console.c:204:10-11: WARNING comparing
pointer to 0.

Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
---
 arch/xtensa/platforms/iss/console.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/xtensa/platforms/iss/console.c b/arch/xtensa/platforms/iss/console.c
index 81f9889..92d4624 100644
--- a/arch/xtensa/platforms/iss/console.c
+++ b/arch/xtensa/platforms/iss/console.c
@@ -201,7 +201,7 @@ static void iss_console_write(struct console *co, const char *s, unsigned count)
 {
 	int len = strlen(s);
 
-	if (s != 0 && *s != 0)
+	if (s && *s != 0)
 		simc_write(1, s, count < len ? count : len);
 }
 
-- 
1.8.3.1