lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Aug 2021 16:21:29 -0700 From: Max Filippov <jcmvbkbc@...il.com> To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> Cc: Chris Zankel <chris@...kel.net>, "open list:TENSILICA XTENSA PORT (xtensa)" <linux-xtensa@...ux-xtensa.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] xtensa: ISS: Fix warning comparing pointer to 0 Hi Jiapeng, On Fri, Jul 30, 2021 at 3:30 AM Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> wrote: > > Fix the following coccicheck warning: > > ./arch/xtensa/platforms/iss/console.c:204:10-11: WARNING comparing > pointer to 0. > > Reported-by: Abaci Robot <abaci@...ux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> > --- > arch/xtensa/platforms/iss/console.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/xtensa/platforms/iss/console.c b/arch/xtensa/platforms/iss/console.c > index 81f9889..92d4624 100644 > --- a/arch/xtensa/platforms/iss/console.c > +++ b/arch/xtensa/platforms/iss/console.c > @@ -201,7 +201,7 @@ static void iss_console_write(struct console *co, const char *s, unsigned count) > { > int len = strlen(s); Here's a bigger issue in this function: s is used in strlen before it is checked for NULL. I've posted another patch that fixes it. > - if (s != 0 && *s != 0) > + if (s && *s != 0) > simc_write(1, s, count < len ? count : len); > } > > -- > 1.8.3.1 > -- Thanks. -- Max
Powered by blists - more mailing lists