linux-kernel - Re: [PATCH] net: let flow have same hash in two directions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210730035924.0cfda450@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 30 Jul 2021 03:59:24 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     zhang kai <zhangkaiheb@....com>
Cc:     davem@...emloft.net, ast@...nel.org, daniel@...earbox.net,
        andrii@...nel.org, kafai@...com, songliubraving@...com, yhs@...com,
        john.fastabend@...il.com, kpsingh@...nel.org,
        krzysztof.kozlowski@...onical.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: let flow have same hash in two directions

On Wed, 28 Jul 2021 18:54:18 +0800 zhang kai wrote:
> using same source and destination ip/port for flow hash calculation
> within the two directions.

Did you observe the hash being different, or just found this by code
inspection? AFAICT the existing code was fine, and probably slightly
faster.