linux-kernel - Re: [PATCH 1/2] memory: omap-gpmc: Clear GPMC_CS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f0a0dfe8-a185-2b14-e12a-ebdd6e2c909f@kernel.org>
Date:   Fri, 30 Jul 2021 13:59:51 +0300
From:   Roger Quadros <rogerq@...nel.org>
To:     Tony Lindgren <tony@...mide.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH 1/2] memory: omap-gpmc: Clear GPMC_CS_CONFIG7 register on
 restore if unused



On 27/07/2021 13:10, Tony Lindgren wrote:
> We want to clear any unused GPMC_CS_CONFIG7 register on restore to
> ensure unused chip selects are not enabled.
> 
> Cc: Roger Quadros <rogerq@...nel.org>
> Signed-off-by: Tony Lindgren <tony@...mide.com>

Acked-by: Roger Quadros <rogerq@...nel.org>

Sorry if you got this twice. I got a bounce back on the previous Ack.

cheers,
-roger

> ---
>  drivers/memory/omap-gpmc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -2595,6 +2595,8 @@ void omap3_gpmc_restore_context(void)
>  				gpmc_context.cs_context[i].config6);
>  			gpmc_cs_write_reg(i, GPMC_CS_CONFIG7,
>  				gpmc_context.cs_context[i].config7);
> +		} else {
> +			gpmc_cs_write_reg(i, GPMC_CS_CONFIG7, 0);
>  		}
>  	}
>  }
>