linux-kernel - Re: [PATCH v13 2/9] PCI: Add pcie_reset_flr to follow calling convention of other reset methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 2 Aug 2021 01:04:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     Amey Narkhede <ameynarkhede03@...il.com>,
        Bjorn Helgaas <helgaas@...nel.org>
Cc:     kbuild-all@...ts.01.org, alex.williamson@...hat.com,
        Raphael Norwitz <raphael.norwitz@...anix.com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        kw@...ux.com, Shanker Donthineni <sdonthineni@...dia.com>,
        Sinan Kaya <okaya@...nel.org>, Len Brown <lenb@...nel.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH v13 2/9] PCI: Add pcie_reset_flr to follow calling
 convention of other reset methods

Hi Amey,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on pci/next]
[also build test WARNING on pm/linux-next cryptodev/master crypto/master linus/master v5.14-rc3 next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Amey-Narkhede/PCI-Expose-and-manage-PCI-device-reset/20210801-222806
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: i386-randconfig-s002-20210801 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/ce304ecb5f2709fa58ef6f16cf8e89ddbd7e42cd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Amey-Narkhede/PCI-Expose-and-manage-PCI-device-reset/20210801-222806
        git checkout ce304ecb5f2709fa58ef6f16cf8e89ddbd7e42cd
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/pci/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
   drivers/pci/pci.c:1052:13: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1052:21: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1052:31: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1052:39: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1061:35: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1061:54: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1062:19: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1062:37: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1092:23: sparse: sparse: invalid assignment: |=
   drivers/pci/pci.c:1092:23: sparse:    left side has type unsigned short
   drivers/pci/pci.c:1092:23: sparse:    right side has type restricted pci_power_t
   drivers/pci/pci.c:1097:57: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1119:28: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted pci_power_t [usertype] current_state @@     got int @@
   drivers/pci/pci.c:1119:28: sparse:     expected restricted pci_power_t [usertype] current_state
   drivers/pci/pci.c:1119:28: sparse:     got int
   drivers/pci/pci.c:1168:36: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted pci_power_t [usertype] current_state @@     got int @@
   drivers/pci/pci.c:1168:36: sparse:     expected restricted pci_power_t [usertype] current_state
   drivers/pci/pci.c:1168:36: sparse:     got int
   drivers/pci/pci.c:1340:13: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1340:21: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1342:18: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1342:26: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1365:13: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1365:22: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1372:46: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1372:54: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:1730:38: sparse: sparse: array of flexible structures
   drivers/pci/pci.c:1917:36: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted pci_power_t [usertype] current_state @@     got int @@
   drivers/pci/pci.c:1917:36: sparse:     expected restricted pci_power_t [usertype] current_state
   drivers/pci/pci.c:1917:36: sparse:     got int
   drivers/pci/pci.c:2313:44: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:2614:61: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:2615:45: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:2804:20: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:2804:38: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:2827:49: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pci.c:2827:67: sparse: sparse: restricted pci_power_t degrades to integer
>> drivers/pci/pci.c:4636:6: sparse: sparse: symbol 'pcie_has_flr' was not declared. Should it be static?
   drivers/pci/pci.c:4768:13: sparse: sparse: invalid assignment: |=
   drivers/pci/pci.c:4768:13: sparse:    left side has type unsigned short
   drivers/pci/pci.c:4768:13: sparse:    right side has type restricted pci_power_t
   drivers/pci/pci.c:4773:13: sparse: sparse: invalid assignment: |=
   drivers/pci/pci.c:4773:13: sparse:    left side has type unsigned short
   drivers/pci/pci.c:4773:13: sparse:    right side has type restricted pci_power_t

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (38524 bytes)