linux-kernel - Re: [PATCH v13 2/9] PCI: Add pcie_reset_flr to follow calling convention of other reset methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202108020257.WIyTlyUI-lkp@intel.com>
Date:   Mon, 2 Aug 2021 02:17:44 +0800
From:   kernel test robot <lkp@...el.com>
To:     Amey Narkhede <ameynarkhede03@...il.com>,
        Bjorn Helgaas <helgaas@...nel.org>
Cc:     clang-built-linux@...glegroups.com, kbuild-all@...ts.01.org,
        alex.williamson@...hat.com,
        Raphael Norwitz <raphael.norwitz@...anix.com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        kw@...ux.com, Shanker Donthineni <sdonthineni@...dia.com>,
        Sinan Kaya <okaya@...nel.org>, Len Brown <lenb@...nel.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH v13 2/9] PCI: Add pcie_reset_flr to follow calling
 convention of other reset methods

Hi Amey,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on pci/next]
[also build test WARNING on pm/linux-next cryptodev/master crypto/master linus/master v5.14-rc3 next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Amey-Narkhede/PCI-Expose-and-manage-PCI-device-reset/20210801-222806
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-randconfig-r025-20210801 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 4f71f59bf3d9914188a11d0c41bedbb339d36ff5)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/ce304ecb5f2709fa58ef6f16cf8e89ddbd7e42cd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Amey-Narkhede/PCI-Expose-and-manage-PCI-device-reset/20210801-222806
        git checkout ce304ecb5f2709fa58ef6f16cf8e89ddbd7e42cd
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/pci/pci.c:4636:6: warning: no previous prototype for function 'pcie_has_flr' [-Wmissing-prototypes]
   bool pcie_has_flr(struct pci_dev *dev)
        ^
   drivers/pci/pci.c:4636:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   bool pcie_has_flr(struct pci_dev *dev)
   ^
   static 
   1 warning generated.


vim +/pcie_has_flr +4636 drivers/pci/pci.c

3775a209d38aa3 Casey Leedom      2013-08-06  4628  
a60a2b73ba69ab Christoph Hellwig 2017-04-14  4629  /**
a60a2b73ba69ab Christoph Hellwig 2017-04-14  4630   * pcie_has_flr - check if a device supports function level resets
a60a2b73ba69ab Christoph Hellwig 2017-04-14  4631   * @dev: device to check
a60a2b73ba69ab Christoph Hellwig 2017-04-14  4632   *
a60a2b73ba69ab Christoph Hellwig 2017-04-14  4633   * Returns true if the device advertises support for PCIe function level
a60a2b73ba69ab Christoph Hellwig 2017-04-14  4634   * resets.
a60a2b73ba69ab Christoph Hellwig 2017-04-14  4635   */
2d2917f7747805 Alex Williamson   2018-08-09 @4636  bool pcie_has_flr(struct pci_dev *dev)
3775a209d38aa3 Casey Leedom      2013-08-06  4637  {
f65fd1aa4f9881 Sasha Neftin      2017-04-03  4638  	if (dev->dev_flags & PCI_DEV_FLAGS_NO_FLR_RESET)
a60a2b73ba69ab Christoph Hellwig 2017-04-14  4639  		return false;
3775a209d38aa3 Casey Leedom      2013-08-06  4640  
e8213ae6f11e62 Amey Narkhede     2021-08-01  4641  	return FIELD_GET(PCI_EXP_DEVCAP_FLR, dev->devcap) == 1;
a60a2b73ba69ab Christoph Hellwig 2017-04-14  4642  }
3775a209d38aa3 Casey Leedom      2013-08-06  4643  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (35557 bytes)