linux-kernel - Re: [PATCH] x86/asm: fix gcc-5 enqcmds() build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <70BD5ED0-BA08-438E-BF14-C49827617C90@zytor.com>
Date:   Mon, 02 Aug 2021 18:15:00 +0200
From:   "H. Peter Anvin" <hpa@...or.com>
To:     Arnd Bergmann <arnd@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org
CC:     Arnd Bergmann <arnd@...db.de>, Dave Jiang <dave.jiang@...el.com>,
        Tony Luck <tony.luck@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Ben Widawsky <ben.widawsky@...el.com>,
        Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
        Arvind Sankar <nivedita@...m.mit.edu>,
        Peter Zijlstra <peterz@...radead.org>,
        Vinod Koul <vkoul@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/asm: fix gcc-5 enqcmds() build failure

NAK.

The type of arguments to condition code arguments should be bool.

On August 2, 2021 4:53:42 PM GMT+02:00, Arnd Bergmann <arnd@...nel.org> wrote:
>From: Arnd Bergmann <arnd@...db.de>
>
>Building drivers/dma/idxd/submit.o with gcc-5.5 results in a cryptic
>error messages:
>
>arch/x86/include/asm/special_insns.h: Assembler messages:
>arch/x86/include/asm/special_insns.h:286: Error: operand size mismatch for `setz'
>make[5]: *** [scripts/Makefile.build:272: drivers/dma/idxd/submit.o] Error 1
>
>It seems that this happens for 32-bit arguments when the instruction
>expects an 8-bit argument. Change the type of the local variable
>accordingly to get a clean build.
>
>Fixes: 7f5933f81bd8 ("x86/asm: Add an enqcmds() wrapper for the ENQCMDS instruction")
>Fixes: 8e50d392652f ("dmaengine: idxd: Add shared workqueue support") # guessed
>Signed-off-by: Arnd Bergmann <arnd@...db.de>
>---
> arch/x86/include/asm/special_insns.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/x86/include/asm/special_insns.h b/arch/x86/include/asm/special_insns.h
>index f3fbb84ff8a7..33264839f99e 100644
>--- a/arch/x86/include/asm/special_insns.h
>+++ b/arch/x86/include/asm/special_insns.h
>@@ -275,7 +275,7 @@ static inline int enqcmds(void __iomem *dst, const void *src)
> {
> 	const struct { char _[64]; } *__src = src;
> 	struct { char _[64]; } __iomem *__dst = dst;
>-	int zf;
>+	u8 zf;
> 
> 	/*
> 	 * ENQCMDS %(rdx), rax

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.