linux-kernel - Re: [PATCH v4] crypto: sun8i-ss: fix multiple memory leaks in sun8i_ss_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YQg4+skrb9dxMgHw@Red>
Date:   Mon, 2 Aug 2021 20:27:06 +0200
From:   Corentin Labbe <clabbe.montjoie@...il.com>
To:     Dongliang Mu <mudongliangabcd@...il.com>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Ard Biesheuvel <ardb@...nel.org>,
        Xiang Chen <chenxiang66@...ilicon.com>,
        Eric Biggers <ebiggers@...gle.com>,
        Colin Ian King <colin.king@...onical.com>,
        linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] crypto: sun8i-ss: fix multiple memory leaks in
 sun8i_ss_hash_run

Le Mon, Jul 26, 2021 at 11:25:21PM +0800, Dongliang Mu a écrit :
> In sun8i_ss_hash_run, all the dma_mmap_sg/single will cause memory leak
> due to no corresponding unmap operation if errors happen.
> 
> Fix this by adding error handling part for all the dma_mmap_sg/single.
> 

Hello

I have nearly the same comment than on your sun8i-ce patch, (copy result only if err===0 and wording).

Regards