linux-kernel - Re: [PATCH] amd/iommu: fix logic bug in amd_iommu_report_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d9bf4fc-4956-70fd-6d80-2b0ee92a571@google.com>
Date:   Sun, 1 Aug 2021 20:52:42 -0700 (PDT)
From:   David Rientjes <rientjes@...gle.com>
To:     Luigi Rizzo <lrizzo@...gle.com>
cc:     Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org,
        Joerg Roedel <joro@...tes.org>, rizzo.unipi@...il.com,
        Suravee Suthikulpanit <suravee.suthikulpanit@....com>
Subject: Re: [PATCH] amd/iommu: fix logic bug in
 amd_iommu_report_page_fault()

On Sat, 31 Jul 2021, Luigi Rizzo wrote:

> amd_iommu_report_page_fault() has two print paths, depending on whether or
> not it can find a pci device. But the code erroneously enters the second
> path if the rate limiter in the first path triggers:
>   if (dev_data && ratelimit(A)) { A; } else if (ratelimit(B)) { B; }
> The correct code should be
>   if (dev_data) { if (ratelimit(A)) { A;} } else if (ratelimit(B)) { B; }
> 
> Signed-off-by: Luigi Rizzo <lrizzo@...gle.com>

Acked-by: David Rientjes <rientjes@...gle.com>

This would be very helpful so we don't erroneously classify these KERN_ERR 
messages as dangerous.