linux-kernel - Re: [PATCH] amd/iommu: fix logic bug in amd_iommu_report_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YQf9h+qvWCx6D7XT@8bytes.org>
Date:   Mon, 2 Aug 2021 16:13:27 +0200
From:   Joerg Roedel <joro@...tes.org>
To:     Luigi Rizzo <lrizzo@...gle.com>
Cc:     Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org,
        David Rientjes <rientjes@...gle.com>, rizzo.unipi@...il.com,
        Suravee Suthikulpanit <suravee.suthikulpanit@....com>
Subject: Re: [PATCH] amd/iommu: fix logic bug in amd_iommu_report_page_fault()

On Sat, Jul 31, 2021 at 12:26:37PM -0700, Luigi Rizzo wrote:
> amd_iommu_report_page_fault() has two print paths, depending on whether or
> not it can find a pci device. But the code erroneously enters the second
> path if the rate limiter in the first path triggers:
>   if (dev_data && ratelimit(A)) { A; } else if (ratelimit(B)) { B; }
> The correct code should be
>   if (dev_data) { if (ratelimit(A)) { A;} } else if (ratelimit(B)) { B; }
> 
> Signed-off-by: Luigi Rizzo <lrizzo@...gle.com>
> ---
>  drivers/iommu/amd/iommu.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Thanks, but I queued this patch already:

	https://lore.kernel.org/r/YPgk1dD1gPMhJXgY@wantstofly.org

Regards,

	Joerg