linux-kernel - Re: [PATCH v1 1/1] platform/surface: aggregator: Ouse y instead of objs in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YQmXQlZqoUCHhSdn@smile.fi.intel.com>
Date:   Tue, 3 Aug 2021 22:21:38 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Maximilian Luz <luzmaximilian@...il.com>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mark Gross <mgross@...ux.intel.com>
Subject: Re: [PATCH v1 1/1] platform/surface: aggregator: Ouse y instead of
 objs in Makefile

On Tue, Aug 03, 2021 at 08:40:10PM +0200, Maximilian Luz wrote:
> On 8/3/21 7:50 PM, Andy Shevchenko wrote:
> > The 'objs' is for user space tools, for the kernel modules
> > we should use 'y'.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> Thank you! I was previously not aware of that distinction. Two small
> notes:
> 
>  - There is a typo in the subject line.
>  - With that change, the ifeq could be placed in-line (see note below).

Will address both.

> All in all looks good to me (assuming the typo gets fixed).
> 
> Reviewed-by: Maximilian Luz <luzmaximilian@...il.com>

Thanks!

-- 
With Best Regards,
Andy Shevchenko