linux-kernel - Re: [PATCH] soc: ixp4xx/qmgr: fix invalid _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Aug 2021 01:36:54 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Krzysztof Halasa <khalasa@...p.pl>,
        Krzysztof Hałasa <khc@...waw.pl>,
        Arnd Bergmann <arnd@...db.de>,
        kernel test robot <lkp@...el.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: ixp4xx/qmgr: fix invalid __iomem access

On Tue, Aug 3, 2021 at 10:17 AM Arnd Bergmann <arnd@...nel.org> wrote:

> From: Arnd Bergmann <arnd@...db.de>
>
> Sparse reports a compile time warning when dereferencing an
> __iomem pointer:
>
> drivers/soc/ixp4xx/ixp4xx-qmgr.c:149:37: warning: dereference of noderef expression
> drivers/soc/ixp4xx/ixp4xx-qmgr.c:153:40: warning: dereference of noderef expression
> drivers/soc/ixp4xx/ixp4xx-qmgr.c:154:40: warning: dereference of noderef expression
> drivers/soc/ixp4xx/ixp4xx-qmgr.c:174:38: warning: dereference of noderef expression
> drivers/soc/ixp4xx/ixp4xx-qmgr.c:174:44: warning: dereference of noderef expression
>
> Use __raw_readl() here for consistency with the rest of the file.
> This should really get converted to some proper accessor, as the
> __raw functions are not meant to be used in drivers, but the driver
> has used these since the start, so for the moment, let's only fix
> the warning.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: d4c9e9fc9751 ("IXP42x: Add QMgr support for IXP425 rev. A0 processors.")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij