linux-kernel - Re: [PATCH] soc: ixp4xx: fix printing resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZOzCPKMiCaB3McYAmXZ1oC=L6jKER9a7g2oM6EHE55Fg@mail.gmail.com>
Date:   Wed, 4 Aug 2021 01:37:42 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Krzysztof Halasa <khalasa@...p.pl>, Arnd Bergmann <arnd@...db.de>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: ixp4xx: fix printing resources

On Tue, Aug 3, 2021 at 10:20 AM Arnd Bergmann <arnd@...nel.org> wrote:

> From: Arnd Bergmann <arnd@...db.de>
>
> When compile-testing with 64-bit resource_size_t, gcc reports an invalid
> printk format string:
>
> In file included from include/linux/dma-mapping.h:7,
>                  from drivers/soc/ixp4xx/ixp4xx-npe.c:15:
> drivers/soc/ixp4xx/ixp4xx-npe.c: In function 'ixp4xx_npe_probe':
> drivers/soc/ixp4xx/ixp4xx-npe.c:694:18: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]
>     dev_info(dev, "NPE%d at 0x%08x-0x%08x not available\n",
>
> Use the special %pR format string to print the resources.
>
> Fixes: 0b458d7b10f8 ("soc: ixp4xx: npe: Pass addresses as resources")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij