linux-kernel - Re: [PATCH 2/2] perf: remove shebang from scripts/{perl,python}/*.{pl,py}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c62e5f1-be91-0104-898b-250d9f533f8f@kernel.org>
Date:   Wed, 4 Aug 2021 07:49:36 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Adrian Hunter <adrian.hunter@...el.com>, acme@...hat.com
Cc:     linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andi Kleen <ak@...ux.intel.com>,
        Ingo Molnar <mingo@...hat.com>, Jiri Olsa <jolsa@...hat.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Leo Yan <leo.yan@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 2/2] perf: remove shebang from
 scripts/{perl,python}/*.{pl,py}

On 03. 08. 21, 13:44, Adrian Hunter wrote:
> On 26/07/21 12:14 pm, Jiri Slaby wrote:
>> The scripts cannot be executed on their own. The python ones were always
>> installed without x permissions, the perl ones fail anyway:
>>    BEGIN failed--compilation aborted at /usr/lib/perf-core/scripts/perl/rw-by-pid.pl line 18.
>> so there is no point to have a shebang in them. This causes rpmlint to
>> complain too:
>>    W: non-executable-script /usr/lib/perf-core/scripts/perl/rw-by-file.pl 644 /usr/bin/perl -w
>>
>> Hence drop shebangs in them all and remove x permissions in the
>> repository. If anyone wants some of them executable, they need to fix
>> the install scripts first.
>>
>> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
>> Cc: Adrian Hunter <adrian.hunter@...el.com>
>> Cc: Andi Kleen <ak@...ux.intel.com>
>> Cc: Ingo Molnar <mingo@...hat.com>
>> Cc: Jiri Olsa <jolsa@...hat.com>
>> Cc: Kan Liang <kan.liang@...ux.intel.com>
>> Cc: Leo Yan <leo.yan@...aro.org>
>> Cc: Mark Rutland <mark.rutland@....com>
>> Cc: Namhyung Kim <namhyung@...nel.org>
>> Cc: Peter Zijlstra <peterz@...radead.org>
>> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
>> ---
>>   tools/perf/scripts/perl/rw-by-file.pl            | 1 -
>>   tools/perf/scripts/perl/rw-by-pid.pl             | 1 -
>>   tools/perf/scripts/perl/rwtop.pl                 | 1 -
>>   tools/perf/scripts/perl/wakeup-latency.pl        | 1 -
>>   tools/perf/scripts/python/exported-sql-viewer.py | 1 -
> 
> exported-sql-viewer.py is a standalone executable

That's great, but in fact noone can run it when make-installed as I 
stated above:

 >> If anyone wants some of them executable, they need to fix
 >> the install scripts first.

See:
$(INSTALL) scripts/python/*.py -m 644 -t 
'$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python';

thanks,
-- 
js
suse labs