linux-kernel - Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-78538c33-fe7b-4eea-83c7-5dfe4f5824d1@palmerdabbelt-glaptop>
Date:   Tue, 03 Aug 2021 20:55:01 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     geert@...ux-m68k.org
CC:     bmeng.cn@...il.com, lewis.hanly@...rochip.com,
        Atish Patra <Atish.Patra@....com>,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        bin.meng@...driver.com
Subject:     Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node

On Fri, 16 Jul 2021 04:34:02 PDT (-0700), geert@...ux-m68k.org wrote:
> Hi Bin,
>
> On Fri, Jul 16, 2021 at 12:14 PM Bin Meng <bmeng.cn@...il.com> wrote:
>> On Fri, Jul 16, 2021 at 5:23 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>> > On Fri, Jul 2, 2021 at 3:44 AM Bin Meng <bmeng.cn@...il.com> wrote:
>> > > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
>> > > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
>> > > @@ -9,6 +9,10 @@ / {
>> > >         model = "Microchip MPFS Icicle Kit";
>> > >         compatible = "microchip,mpfs-icicle-kit";
>> > >
>> > > +       aliases {
>> > > +               ethernet0 = &emac1;
>> > > +       };
>> > > +
>> > >         chosen {
>> > >         };
>> >
>> > This should be added to the board DTS (microchip-mpfs-icicle-kit.dts)
>> > instead.
>>
>> I was wondering the same thing before doing this, but when I checked
>> all other DTS in arch/riscv/boot I found the aliases node is put in
>> the SoC dtsi file instead of the board on so I think that's the
>> convention.
>
> The numbering of the aliases is supposed to match the labels on the
> board, hence it is board-specific, not SoC-specific.
>
> Gr{oetje,eeting}s,
>
>                         Geert

I don't see a v2 of this.