linux-kernel - Re: [PATCH v2 0/6] CAN: Add support for CAN in AM65,J721e and AM64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <caa97a4e-5e84-2aa6-3a4c-3bbe29fb7a58@siemens.com>
Date:   Thu, 5 Aug 2021 14:49:10 +0200
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     Aswath Govindraju <a-govindraju@...com>, Nishanth Menon <nm@...com>
Cc:     linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        Lokesh Vutla <lokeshvutla@...com>,
        Faiz Abbas <faiz_abbas@...com>
Subject: Re: [PATCH v2 0/6] CAN: Add support for CAN in AM65,J721e and AM64

On 05.08.21 14:44, Aswath Govindraju wrote:
> Hi Jan,
> 
> On 05/08/21 6:10 pm, Jan Kiszka wrote:
>> On 05.08.21 14:32, Aswath Govindraju wrote:
>>> Hi,
>>>
>>> On 02/08/21 6:15 pm, Nishanth Menon wrote:
>>>> On 15:40-20210726, Aswath Govindraju wrote:
>>>>> The following series of patches add support for CAN in SoC's AM65, J721e
>>>>> and AM64.
>>>>>
>>>>> This patch series is dependent on [1] and [2] and I have requested for an
>>>>> immutable tag from the Marc Kleine-Budde(maintainer of net tree).
>>>>>
>>>>> [1] - https://lore.kernel.org/patchwork/patch/1423048/
>>>>> [2] - https://www.spinics.net/lists/linux-can/msg08108.html
>>>>>
>>>>> changes since v1 -
>>>>> - changed the message ram configuration to use the maximum value
>>>>>   in each field, for better performance.
>>>>>
>>>>> Aswath Govindraju (3):
>>>>>   arm64: dts: ti: am654-base-board: Disable mcan nodes
>>>>>   arm64: dts: ti: k3-am64-main: Add support for MCAN
>>>>>   arm64: dts: ti: k3-am642-evm/sk: Add support for main domain mcan
>>>>>     nodes in EVM and disable them on SK
>>>>>
>>>>> Faiz Abbas (3):
>>>>>   arm64: dts: ti: k3-am65-mcu: Add Support for MCAN
>>>>>   arm64: dts: ti: k3-j721e: Add support for MCAN nodes
>>>>>   arm64: dts: ti: k3-j721e-common-proc-board: Add support for mcu_mcan
>>>>>     nodes
>>>>
>>>> I noticed in my checkup: https://pastebin.ubuntu.com/p/zSk39M943N/
>>>> warnings with dtbs_check, I think the bindings need a little more help
>>>> here (please also notice the iot platform warnings getting introduced).
>>>>
>>>
>>> Jan,
>>>
>>> Can you please point me to the schematics for iot platform? Also, is CAN
>>> subsystem brought out on the iot platform boards?
>>
>> Schematics aren't publicly available. If you have specific questions, I
>> may help, though.
>>
>> CAN is not in use yet (not connected AFAIK).
>>
> 
> Thank you for clarifying this. I will disable the CAN DT nodes in
> k3-am65-iot2050-common.dtsi in my respin.
> 

That is not a problem for the current design, so you can go ahead with it.

Current defconfig - though not yet upstream based - can be found at [1].
The CAN subsystem is enabled, but not the AM65x CAN driver.

Jan

[1]
https://github.com/siemens/meta-iot2050/tree/master/recipes-kernel/linux/files

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux